Skip to content

Solvers: Replace uses of namespacet::follow #8235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2024
Merged

Solvers: Replace uses of namespacet::follow #8235

merged 1 commit into from
May 9, 2024

Conversation

tautschnig
Copy link
Collaborator

This is deprecated. Use suitable variants of follow_tag instead.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov Codecov
Copy link

codecov bot commented Mar 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.54945% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 77.62%. Comparing base (ae7d311) to head (8a0782b).

Files Patch % Lines
src/solvers/flattening/bv_pointers.cpp 0.00% 20 Missing ⚠️
src/solvers/smt2/smt2_conv.cpp 50.00% 14 Missing ⚠️
src/solvers/flattening/boolbv_update.cpp 0.00% 8 Missing ⚠️
src/solvers/flattening/boolbv_typecast.cpp 90.00% 1 Missing ⚠️
...vers/smt2_incremental/encoding/struct_encoding.cpp 90.00% 1 Missing ⚠️
src/solvers/strings/string_refinement.cpp 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8235      +/-   ##
===========================================
- Coverage    77.81%   77.62%   -0.20%     
===========================================
  Files         1721     1721              
  Lines       189460   189965     +505     
  Branches     18401    18411      +10     
===========================================
+ Hits        147432   147459      +27     
- Misses       42028    42506     +478

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig force-pushed the cleanup/no-follow-solvers branch from b32e7de to cdb546c Compare March 19, 2024 12:50
@tautschnig tautschnig self-assigned this Mar 19, 2024
@tautschnig tautschnig force-pushed the cleanup/no-follow-solvers branch from cdb546c to 15de7db Compare March 19, 2024 14:37
@tautschnig tautschnig removed their assignment Mar 19, 2024
@martin-cs martin-cs removed their assignment May 5, 2024
@tautschnig
Solvers: Replace uses of namespacet::follow
8a0782b 
This is deprecated. Use suitable variants of `follow_tag` instead.
@tautschnig tautschnig force-pushed the cleanup/no-follow-solvers branch from 15de7db to 8a0782b Compare May 6, 2024 11:24
@tautschnig tautschnig assigned esteffin and thomasspriggs and unassigned kroening May 6, 2024
@tautschnig tautschnig merged commit f18b509 into diffblue:develop May 9, 2024
38 of 40 checks passed
@tautschnig tautschnig deleted the cleanup/no-follow-solvers branch May 9, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasspriggs thomasspriggs thomasspriggs left review comments

@peterschrammel peterschrammel peterschrammel approved these changes

@martin-cs martin-cs martin-cs approved these changes

@TGWDB TGWDB Awaiting requested review from TGWDB TGWDB is a code owner

@esteffin esteffin Awaiting requested review from esteffin

@kroening kroening Awaiting requested review from kroening kroening is a code owner

Assignees

@peterschrammel peterschrammel

@esteffin esteffin

@thomasspriggs thomasspriggs

@TGWDB TGWDB

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tautschnig @peterschrammel @martin-cs @thomasspriggs @kroening @esteffin @TGWDB